This repository has been archived by the owner on Jan 7, 2022. It is now read-only.
Deploy from CircleCI to DockerHub #67
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
calebmarchent
force-pushed
the
circleci_to_dockerhub_pipeline
branch
2 times, most recently
from
681cec4
to
e29254c
Compare
In CircleCI we already compile LogDevice within a Docker image. For this iteration, of the CI to DockerHub flow, we use a targeted Dockerfile to pulls together the compiled artefacts into a publishable Docker image; that users can download and run; following the builder/production image structure implemented in Docker.ubuntu. During testing, "Illegal Instruction" crashes were observed in using the resulting container; to resolve this we apply the PORTABLE CMake option. See https://forums.docker.com/t/getting-illegal-instruction-when-i-run-my-program-inside-container/43919 While in the future, it is planned to only create new Dockerimages on successful builds, this limit is omitted from the current diff pending resolution of the current failures.
calebmarchent
force-pushed
the
circleci_to_dockerhub_pipeline
branch
from
e29254c
to
ee19b09
Compare
calebmarchent
changed the title
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
calebmarchent
force-pushed
the
circleci_to_dockerhub_pipeline
branch
from
376f0ff
to
91e3a67
Compare
There was a problem hiding this comment.
@calebmarchent has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 16, 2020
…ps.py build (#67) Summary: Pull Request resolved: facebook/sapling#67 With this change it will be possible to build dependencies of and run integration tests using getdeps.py. This is the first goal of Q4 as per https://fb.quip.com/v8YzAYNSYgot: "Get Open Source version of integration tests running on Legocastle". Before this diff: The OSS integration tests run now on GitHub by: - Building some test dependencies with getdeps.py - Building some test dependencies with homebrew/apt-get - Running tests via python script The OSS integration tests were not running on Sandcastle. After this diff: The OSS integration tests run on Github by: - Building and executing tests via getdeps.py (execution of tests happens by getdeps.py calling Make calling python script) The OSS integration tests run on Sandcastle using the same getdeps.py setup as Github. Reviewed By: krallin Differential Revision: D24253268 fbshipit-source-id: cae249b72d076222673b8bbe4ec21866dcdbb253
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In CircleCI we already compile LogDevice within a Docker image. For
this iteration, of the CI to DockerHub flow, we use a targeted Dockerfile
to pulls together the compiled artefacts into a publishable Docker image;
that users can download and run; following the builder/production image
structure implemented in Docker.ubuntu.
During testing, "Illegal Instruction" crashes were observed in using the
resulting container; to resolve this we apply the PORTABLE CMake option.
See https://forums.docker.com/t/getting-illegal-instruction-when-i-run-my-program-inside-container/43919
While in the future, it is planned to only create new Dockerimages on
successful builds, this limit is omitted from the current diff pending
resolution of the current failures.