Add tvOS support (dependencies and headers) #1032
Conversation
…ebDriverAgent into fb-merge/unit-tests
| @@ -1 +1 @@ | |||
| github "marekcirkos/RoutingHTTPServer" "v1.0.1" | |||
| github "shvul/RoutingHTTPServer" "v1.0.2" | |||
There was a problem hiding this comment.
What exactly has been changed in this module that is has to be updated?
There was a problem hiding this comment.
Previous version doesn't have tvOS target, so Carthage cannot build it for our purposes. Also, CocoaHTTPServer lib was updated. I added small fix for tvOS compiling.
There was a problem hiding this comment.
I'd say it makes sense to create a PR to update the original rep rather than switching to the custom one.
There was a problem hiding this comment.
The original repo has not been updated for a long time. @marekcirkos made a fork for his fixes. Do you suggest to make pr to his fork?
There was a problem hiding this comment.
yes, this makes sense, because he is anyway the only person who could approve and merge this PR
There was a problem hiding this comment.
@mykola-mokhnach here it is: marekcirkos/RoutingHTTPServer#1
Let's continue when @marekcirkos merge it and create new release
| @@ -31,7 +31,9 @@ | |||
| @property(getter=isIdleAnimationWaitEnabled) BOOL idleAnimationWaitEnabled; // @synthesize idleAnimationWaitEnabled=_idleAnimationWaitEnabled; | |||
| @property(nonatomic) BOOL doesNotHandleUIInterruptions; // @synthesize doesNotHandleUIInterruptions=_doesNotHandleUIInterruptions; | |||
| @property(readonly) BOOL fauxCollectionViewCellsEnabled; | |||
| #if !TARGET_OS_TV | |||
There was a problem hiding this comment.
I think TODO can be removed now
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <Scheme | |||
| LastUpgradeVersion = "0900" | |||
| LastUpgradeVersion = "1000" | |||
There was a problem hiding this comment.
I this necessary to update this file?
There was a problem hiding this comment.
It's not necessary. As I remember, I just update repo to "recommended settings". If I revert its update, it will cause merge conflict in further pr's. So, if it is not a serious problem, I will leave this file as it is. It would be updated in next pr's.
|
@mykola-mokhnach Just a quick note, that it would take some time to update other part of the tvOS logic to support Appium based features (if possible). |
|
@shvul Make it simple. I would rather merge the basic functionality we have now so then we can create more PRs and make it more advanced if needed |
|
Do we have any update on this integration ? |
|
@g-tiwari I'm not able to make all changes to merge with Appium fork due to a huge workload. Also, Appium version of WDA uses a lot of extra libs, that doesn't support tvOS. So, first of all you may try to add support to them by your own :) |
PROBLEM
Add support for tvOS #640
SOLUTION
NOTES
Tests results: https://travis-ci.org/shvul/WebDriverAgent/builds/456840661
WDA tests issue would be fixed in next pr: https://travis-ci.org/shvul/WebDriverAgent/builds/456857954