Skip to content
This repository has been archived by the owner on Dec 13, 2018. It is now read-only.

Use atom-ide-busy-signal while waiting for Linter V1 providers #18

Closed
Arcanemagus opened this issue Sep 13, 2017 · 3 comments
Closed

Use atom-ide-busy-signal while waiting for Linter V1 providers #18

Arcanemagus opened this issue Sep 13, 2017 · 3 comments

Comments

@Arcanemagus
Copy link
Contributor

Arcanemagus commented Sep 13, 2017

Description

It appears that the atom-ide-busy-signal feature isn't initializing for me, at least I can't figure out how to get it to show up.

Expected Behavior

There should be something similar to this from the README showing:
image

Actual Behavior

No busy signal appears to be active:
image

Versions

  • Atom: 1.21.0-beta0
  • Client OS: Windows 10 Enterprise x64

Additional Details

At first I was trying with linter, linter-ui-default, and busy-signal active, but disabling all those packages (and restarting Atom!) doesn't appear to have gotten this to show up.

@damieng
Copy link

damieng commented Sep 13, 2017

It's a service you have to specifically implement and unfortunately none of the language servers have any concept of busy as it isn't in the spec.

I was considering wiring it up for startup and shutdown in atom-languageclient so everybody would get it almost automatically for at least that (they'd just need to add the relevant service to their package.json)

@Arcanemagus
Copy link
Contributor Author

Arcanemagus commented Sep 13, 2017

What about the linter provider translations? It should be pretty simple to wire it up for those since that's being handled through here (I think?).

@hansonw hansonw changed the title atom-ide-busy-signal feature doesn't work? Use atom-ide-busy-signal while waiting for Linter V1 providers Sep 13, 2017
@hansonw
Copy link
Contributor

hansonw commented Sep 13, 2017

Yeah this makes a lot of sense to do

facebook-github-bot pushed a commit to facebookarchive/nuclide that referenced this issue Sep 14, 2017
Summary:
This wires up the diagnostics package to report busy status while waiting on V1 Linters, which work with promises.

I used the generic wording `${providerName}: running on "file"` but open to suggestions.

facebookarchive/atom-ide-ui#18

Reviewed By: matthewwithanm

Differential Revision: D5828830

fbshipit-source-id: 96af8a8cd06190301c3613449c4b19fd8987df0b
hansonw added a commit that referenced this issue Sep 14, 2017
Summary:
This wires up the diagnostics package to report busy status while waiting on V1 Linters, which work with promises.

I used the generic wording `${providerName}: running on "file"` but open to suggestions.

#18

Reviewed By: matthewwithanm

Differential Revision: D5828830

fbshipit-source-id: 96af8a8cd06190301c3613449c4b19fd8987df0b
@hansonw hansonw closed this as completed Sep 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants