Skip to content
This repository has been archived by the owner on Feb 6, 2023. It is now read-only.

Because of BLM banner change, the site became inaccessible #2494

Closed
RAYDENFilipp opened this issue Jul 14, 2020 · 6 comments
Closed

Because of BLM banner change, the site became inaccessible #2494

RAYDENFilipp opened this issue Jul 14, 2020 · 6 comments
Labels
accessibility Accessibility of editor and documentation

Comments

@RAYDENFilipp
Copy link

Because of this change, the site became inaccessible

What happened to links
image

It is hard to see links.

Originally posted by @RAYDENFilipp in #2454 (comment)
@RAYDENFilipp
Copy link
Author

A probable solution might be:

  1. Reduce the greyscale down to 20%-30%.

  2. Remove the grayscale filter at all but leave the banner on all pages to be visible.

@claudiopro
Copy link
Contributor

claudiopro commented Jul 16, 2020 •
edited
Loading

This is a very good bug report. The Draft.js website shouldn't use color alone to render links. This is a common accessibility failure mode for WCAG guidelines.

@rachelnabors
Copy link
Contributor

How about adding some underlines to those links? I got CSS skilllllz...

rachelnabors added a commit to rachelnabors/draft-js that referenced this issue Jul 16, 2020
@rachelnabors
Fixes links accessibility by adding underlines
d7003f6 
Closes facebookarchive#2494
@rachelnabors rachelnabors mentioned this issue Jul 16, 2020
Closed
@claudiopro
Copy link
Contributor

Amazing, you beat me to it @rachelnabors 👏

@claudiopro claudiopro added the accessibility Accessibility of editor and documentation label Jul 16, 2020
@stefan-krajnik
Copy link

You just shot yourself in the foot and now you're trying to fix it with a tape.
Links are just one part of the problem, the website is extremely difficult to read because of missing text highlighting.

Reverting 2a0c5bb commit will fix the issue.

@RAYDENFilipp
Copy link
Author

@stefan-krajnik Exactly. Fixing links won't solve the problem, the whole site causes headache when reading for more than half an hour.

@stefan-krajnik stefan-krajnik mentioned this issue Jul 17, 2020
Closed
@claudiopro claudiopro mentioned this issue Jul 18, 2020
Closed
alicayan008 pushed a commit to alicayan008/draft-js that referenced this issue Jul 4, 2023
@rachelnabors @facebook-github-bot
Fixes links accessibility by adding underlines (#2497)
85e09a5 
Summary:
Closes facebookarchive/draft-js#2494

Pull Request resolved: facebookarchive/draft-js#2497

Differential Revision: D22579546

Pulled By: claudiopro

fbshipit-source-id: 32d78fd6296013878820084ba8fd1e6343285ccb
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
accessibility Accessibility of editor and documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes links accessibility by adding underlines rachelnabors/draft-js
4 participants
@rachelnabors @claudiopro @stefan-krajnik @RAYDENFilipp