Fix #1326 Safari can't focus with draggable parent #1356
Conversation
|
👏 👏 👏 |
|
Thanks for submitting this! The bug is easy to reproduce, and I'm still testing to verify that your change fixes it. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
3 similar comments
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
1 similar comment
|
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
Summary: **Summary** DraftEditors that lived inside draggable parents were useless in Safari. Now they work. Solution found here: react-dnd/react-dnd#178 (comment) **Test Plan** Use the fiddle in #1326 with the updated version. For a quick n dirty, just add this to the stylesheet: `div[contenteditable="true"] { user-select: text;}` Closes facebookarchive/draft-js#1356 Differential Revision: D5901625 fbshipit-source-id: 7d3797286e4040575b9b5503c776bff1e29b67a9
Summary: **Summary** DraftEditors that lived inside draggable parents were useless in Safari. Now they work. Solution found here: react-dnd/react-dnd#178 (comment) **Test Plan** Use the fiddle in #1326 with the updated version. For a quick n dirty, just add this to the stylesheet: `div[contenteditable="true"] { user-select: text;}` Closes facebookarchive/draft-js#1356 Differential Revision: D5901625 fbshipit-source-id: 7d3797286e4040575b9b5503c776bff1e29b67a9
Summary: **Summary** DraftEditors that lived inside draggable parents were useless in Safari. Now they work. Solution found here: react-dnd/react-dnd#178 (comment) **Test Plan** Use the fiddle in #1326 with the updated version. For a quick n dirty, just add this to the stylesheet: `div[contenteditable="true"] { user-select: text;}` Closes facebookarchive/draft-js#1356 Differential Revision: D5901625 fbshipit-source-id: 7d3797286e4040575b9b5503c776bff1e29b67a9
Summary
DraftEditors that lived inside draggable parents were useless in Safari. Now they work.
Solution found here: react-dnd/react-dnd#178 (comment)
Test Plan
Use the fiddle in #1326 with the updated version.
For a quick n dirty, just add this to the stylesheet:
div[contenteditable="true"] { user-select: text;}