This repository was archived by the owner on Feb 6, 2023. It is now read-only.
Move uglifyjs-webpack-plugin to devDependencies #1653
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This dependency got introduced in a separate commit (f8ca29d) from the others in facebookarchive#1644. I imagine this is a mistake since it only provides dev-time tooling.
Contributor
|
Thanks for this PR! |
flarnie
approved these changes
Feb 23, 2018
Contributor
flarnie
left a comment
flarnie
left a comment
There was a problem hiding this comment.
Thanks! Will add to my queue for merging.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@flarnie is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@flarnie has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: **Summary** This dependency got introduced in a separate commit (f8ca29d1a7fa5a8bb89cb9be9a66d12732a0bfa7) from the others in #1644. I imagine this is a mistake since it only provides dev-time tooling. **Test Plan** For development, we can try a fresh install of the project: 1. `rm -rf node_modules` 2. `yarn install`. This runs `npm run build` via the `prepublish` script, so if it works it's good to go. I don't think dependencies and devDependencies are processed any differently in a development environment, so not sure this check is even necessary. For the published package: 1. `mkdir test` 2. `npm init -y` 3. `npm install git+https://github.com/thibaudcolas/draft-js.git#patch-2` 4. `npm ls --depth=1` The `npm ls` result should be: ``` ├─┬ draft-js@0.10.5 (git+https://github.com/thibaudcolas/draft-js.git#cb06920d0f3dea77692680dddba6ec475663c7b2) │ ├── fbjs@0.8.16 │ ├── immutable@3.7.6 │ └── object-assign@4.1.1 ├── UNMET PEER DEPENDENCY react@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0 └── UNMET PEER DEPENDENCY react-dom@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0 ``` Note `uglifyjs-webpack-plugin` is absent, whereas it would have been there with `npm install git+https://github.com/thibaudcolas/draft-js.git#master`. Closes facebookarchive/draft-js#1653 Differential Revision: D7073476 fbshipit-source-id: f69e31c2ca252062d2d66080055fd08b88c5a275
aforismesen
added a commit
to aforismesen/draft-js
that referenced
this pull request
Jul 12, 2024
Summary: **Summary** This dependency got introduced in a separate commit (f8ca29d1a7fa5a8bb89cb9be9a66d12732a0bfa7) from the others in #1644. I imagine this is a mistake since it only provides dev-time tooling. **Test Plan** For development, we can try a fresh install of the project: 1. `rm -rf node_modules` 2. `yarn install`. This runs `npm run build` via the `prepublish` script, so if it works it's good to go. I don't think dependencies and devDependencies are processed any differently in a development environment, so not sure this check is even necessary. For the published package: 1. `mkdir test` 2. `npm init -y` 3. `npm install git+https://github.com/thibaudcolas/draft-js.git#patch-2` 4. `npm ls --depth=1` The `npm ls` result should be: ``` ├─┬ draft-js@0.10.5 (git+https://github.com/thibaudcolas/draft-js.git#cb06920d0f3dea77692680dddba6ec475663c7b2) │ ├── fbjs@0.8.16 │ ├── immutable@3.7.6 │ └── object-assign@4.1.1 ├── UNMET PEER DEPENDENCY react@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0 └── UNMET PEER DEPENDENCY react-dom@^0.14.0 || ^15.0.0-rc || ^16.0.0-rc || ^16.0.0 ``` Note `uglifyjs-webpack-plugin` is absent, whereas it would have been there with `npm install git+https://github.com/thibaudcolas/draft-js.git#master`. Closes facebookarchive/draft-js#1653 Differential Revision: D7073476 fbshipit-source-id: f69e31c2ca252062d2d66080055fd08b88c5a275
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This dependency got introduced in a separate commit (f8ca29d) from the others in #1644. I imagine this is a mistake since it only provides dev-time tooling.
Test Plan
For development, we can try a fresh install of the project:
rm -rf node_modulesyarn install. This runsnpm run buildvia theprepublishscript, so if it works it's good to go.I don't think dependencies and devDependencies are processed any differently in a development environment, so not sure this check is even necessary.
For the published package:
mkdir testnpm init -ynpm install git+https://github.com/thibaudcolas/draft-js.git#patch-2npm ls --depth=1The
npm lsresult should be:Note
uglifyjs-webpack-pluginis absent, whereas it would have been there withnpm install git+https://github.com/thibaudcolas/draft-js.git#master.