This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Fix DOMObserver mutation data for IE #2285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: IE 11 considers the enter keypress that concludes the composition as an input char, which ends up adding a new line to the editor. I am adding code to strip that newline character when processing the mutation event. Differential Revision: D19141003 fbshipit-source-id: fdda84cc70eb5eb5741ee1815d0cad0049354ad9
|
This pull request was exported from Phabricator. Differential Revision: D19141003 |
|
This pull request has been merged in afb708f. |
|
This pull request has been merged in afb708f. |
mmissey
pushed a commit
to mmissey/draft-js
that referenced
this pull request
Mar 24, 2020
Summary: Pull Request resolved: facebookarchive#2285 IE 11 considers the enter keypress that concludes the composition as an input char, which ends up adding a new line to the editor. I am adding code to strip that newline character when processing the mutation event. Reviewed By: mrkev Differential Revision: D19141003 fbshipit-source-id: 53848e42d0e2b45d609e6623cc5d5579168b73fe
vilemj-Viclick
pushed a commit
to kontent-ai/draft-js
that referenced
this pull request
Jul 16, 2020
Summary: Pull Request resolved: facebookarchive#2285 IE 11 considers the enter keypress that concludes the composition as an input char, which ends up adding a new line to the editor. I am adding code to strip that newline character when processing the mutation event. Reviewed By: mrkev Differential Revision: D19141003 fbshipit-source-id: 53848e42d0e2b45d609e6623cc5d5579168b73fe
alicayan008
pushed a commit
to alicayan008/draft-js
that referenced
this pull request
Jul 4, 2023
Summary: Pull Request resolved: facebookarchive/draft-js#2285 IE 11 considers the enter keypress that concludes the composition as an input char, which ends up adding a new line to the editor. I am adding code to strip that newline character when processing the mutation event. Reviewed By: mrkev Differential Revision: D19141003 fbshipit-source-id: 53848e42d0e2b45d609e6623cc5d5579168b73fe
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: IE 11 considers the enter keypress that concludes the composition as an input char, which ends up adding a new line to the editor. I am adding code to strip that newline character when processing the mutation event.
Differential Revision: D19141003
Before the fix (notice the \n character, it gets added to the editor):
After the fix:
