This repository has been archived by the owner on Feb 6, 2023. It is now read-only.
Making sure we don't throw when selecting text on multiple fields #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When selecting text between multiple draft-js Editor fields rendered on a page, an unexpected error happens.
This comment on the code explains why the bug happens: https://github.com/facebook/draft-js/pull/2297/files#diff-92f7a619f202063fc7fd29fcfa73c3e4R46-R50
Test Plan
I created this sandbox to more easily show the issue this PR is solving.
Follow the instructions on the sandbox to repro the issue and see the error: https://codesandbox.io/s/affectionate-rgb-64zsc
Here is what you should see:
