This repository has been archived by the owner on Nov 2, 2019. It is now read-only.
Revert "Updates LoginManager (#516)" #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 90cd224.
joesus
requested review from
ajfigueroa,
davidrothera,
jasonhotsauce,
jawwad,
jgrandelli,
jingping2015,
kalendae,
kartast,
nubbel,
patters,
sammy-SC,
shabbirv,
shergin,
tomw,
wanaya,
yannickl and
Yu-w
as code owners
jawwad
approved these changes
Sep 1, 2019
thisisjak
approved these changes
Sep 1, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 90cd224.
Checklist
swiftlint && swiftlint autocorrect --format)bugfor bug fixes)Pull Request Details
Merging the breaking changes to LoginManager into master was a mistake on my part. The updates to login should occur on a separate branch so that they can all be released together. In the meantime need to revert this change so that we can continue to release version bumps in line with the Objective-C SDK. 🤦♂️
Test Plan
N/A