This repository has been archived by the owner on Dec 13, 2018. It is now read-only.
Fix .jsx extension for #1429 #1544
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Makes sense! Re the original issue: do you mind also adding this to https://github.com/facebook/nuclide/blob/master/pkg/nuclide-flow/lib/main.js#L147 |
Quick fix for the bug, which prevents using `nuclide-js-imports-client` with `.jsx` files extension. facebookarchive#1429
PinkaminaDianePie
force-pushed
the
patch-1
branch
from
611b2d7
to
f62530e
Compare
|
@PinkaminaDianePie has updated the pull request. |
|
@hansonw thanks for mention this, done :) |
There was a problem hiding this comment.
@hansonw is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
Perfect. Thanks for your contribution! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick fix for the bug, which prevents using
nuclide-js-imports-clientwith.jsxfiles extension. #1429