Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Make React tests fast #2187

Closed
wants to merge 22 commits into from
Closed

Make React tests fast #2187

wants to merge 22 commits into from

Commits on Jun 29, 2018

  1. Split React test into multiple files

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    cb4d89d View commit details
    Browse the repository at this point in the history

  2. Put reconciliation tests in a separate folder

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    7e7aa35 View commit details
    Browse the repository at this point in the history

  3. Extract assign/spread tests to a separate file

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    8647703 View commit details
    Browse the repository at this point in the history

  4. Make it possible to run yarn test-react PartialTestName

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    c7f7c45 View commit details
    Browse the repository at this point in the history

  5. Update Jest to 23.2.0

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    4bb8835 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary async/await in tests

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    7947fc0 View commit details
    Browse the repository at this point in the history

  7. Don't run Babel twice on the same code

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    062eac4 View commit details
    Browse the repository at this point in the history

  8. Add a comment to broken test

    @gaearon
    gaearon committed Jun 29, 2018
    Configuration menu
    Copy the full SHA
    c27fd05 View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2018

  1. Make runTest argument an object

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    5c75f48 View commit details
    Browse the repository at this point in the history

  2. Fix a bug with unused argument

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    154d331 View commit details
    Browse the repository at this point in the history

  3. Fix and simplify error handling 

    I introduced a bug where we wouldn't snapshot cases after the first failure, even if failures are expected.
This wasn't a problem in the original code because it separated JSX/no-JSX modes into separate tests.

I fixed my bug by rewriting how error logic works. Hopefully it's more clear now too because it doesn't have to bubble errors all the way up just to run an assertion.
    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    2fdda23 View commit details
    Browse the repository at this point in the history

  4. Give names to snapshots again

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    4ec705b View commit details
    Browse the repository at this point in the history

  5. Fail tests earlier without running Babel

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    6168f6b View commit details
    Browse the repository at this point in the history

  6. Run Prettier on all React tests and fixtures

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    ebdacc4 View commit details
    Browse the repository at this point in the history

  7. Rename a module

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    23f490e View commit details
    Browse the repository at this point in the history

  8. Check React element count inside the test

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    4ab1512 View commit details
    Browse the repository at this point in the history

  9. Add a fast mode for React tests 

    Useful for quick reruns when you don't care about JSX specifically. This lets us skip both 3/4 of tests, and Babel.
    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    5e01a56 View commit details
    Browse the repository at this point in the history

  10. Fix Jest double-runs

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    498cd84 View commit details
    Browse the repository at this point in the history

  11. Use 2 workers on CI

    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    96ddb29 View commit details
    Browse the repository at this point in the history

  12. Remove maxWorkers limitation 

    Didn't help.
    @gaearon
    gaearon committed Jun 30, 2018
    Configuration menu
    Copy the full SHA
    75e66d6 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2018

  1. Remove unnecessary arg

    @gaearon
    gaearon committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    214cd39 View commit details
    Browse the repository at this point in the history

  2. Remove the React copy pasta from tests

    @gaearon
    gaearon committed Jul 2, 2018
    Configuration menu
    Copy the full SHA
    817f00d View commit details
    Browse the repository at this point in the history