update javascript sdk to 2.x call #538
Conversation
Update all.js and all/debug.js 1.x calls to new 2.x sdk.js and sdk/debug.js calls to eliminate pending doom on April 30 2015. Reference: https://developers.facebook.com/docs/javascript/quickstart/v2.3
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
in addition to my previous pull request changing all.js to sdk.js we should, according to the docs, include the version on FB.ini too.
|
@facebook-github-bot just signed it. make it so. |
|
My commit https://github.com/chuckreynolds/wordpress/commit/3e9775149a2dbe1f6564dd6ba8a24a85f0a87d2c will also replace the old pull request for v1 #531 |
|
cc @niallkennedy && @mattwkelly - needs to be addressed before FB's April 30th deadline. https://developers.facebook.com/docs/apps/upgrading |
|
bump for one last glimmer of hope. deadline is upon everybody using this plugin. |
|
What happened here @niallkennedy, @mattwkelly ? The plugin is broken and a fix is just sitting here? |
|
They stopped supporting it a while back. Best to find another plugin option or do the FB comments yourself @ivanblagdan |
ghost
added
the
Update all.js and all/debug.js 1.x calls to new 2.x sdk.js and sdk/debug.js calls to eliminate pending doom on April 30 2015.
Reference: https://developers.facebook.com/docs/javascript/quickstart/v2.3