Skip to content
This repository has been archived by the owner on Jan 1, 2025. It is now read-only.

RecoilRoot doesn't have children attribute #1717

Closed
faradaytrs opened this issue Apr 8, 2022 · 4 comments
Closed

RecoilRoot doesn't have children attribute #1717

faradaytrs opened this issue Apr 8, 2022 · 4 comments
Labels
TypeScript / Flow

Comments

@faradaytrs
Copy link

It stopped working after release of @types/react v18,
FC doesn't have implicit children anymore.
@dqn dqn mentioned this issue Apr 8, 2022
Closed
@tpatalas
Copy link

tpatalas commented Apr 9, 2022 •
edited
Loading

Same issue with React-Query. React-Query Issue #3476. It seems Recoil does not support it yet. Will it be any update?

@drarmstr
Copy link
Contributor

drarmstr commented Apr 9, 2022

It's added in #1718, waiting for a fix on that now. I expect a patch release for this.

@drarmstr drarmstr mentioned this issue Apr 11, 2022
Closed
@hcharley
Copy link

Here is some info on the @types/react 18 upgrade and the breaking change related to the children prop just FYI:

https://solverfox.dev/writing/no-implicit-children/

@drarmstr
Copy link
Contributor

Published 0.7.1

AlexGuz23 pushed a commit to AlexGuz23/Recoil that referenced this issue Nov 3, 2022
@jackwolfskin0302 @facebook-github-bot
Update RecoilRootProps type for React 18 types (#1718)
28407e4 
Summary:
Fixes facebookexperimental/Recoil#1717

Since types/react v18, Implicit `children` was removed from `React.FC`. This change works for types/react v18 and earlier.
DefinitelyTyped/DefinitelyTyped#56210

Pull Request resolved: facebookexperimental/Recoil#1718

Reviewed By: drarmstr

Differential Revision: D35501855

Pulled By: mondaychen

fbshipit-source-id: cf469b96a5220966718270e43e3f0503e144acf3
constanzauanini referenced this issue in terraware/terraware-web Jan 4, 2023
@constanzauanini
Update recoil version
1b12b41
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this issue Mar 5, 2023
@dqn @facebook-github-bot
Update RecoilRootProps type for React 18 types (#1718)
00421fc 
Summary:
Fixes facebookexperimental/Recoil#1717

Since types/react v18, Implicit `children` was removed from `React.FC`. This change works for types/react v18 and earlier.
DefinitelyTyped/DefinitelyTyped#56210

Pull Request resolved: facebookexperimental/Recoil#1718

Reviewed By: drarmstr

Differential Revision: D35501855

Pulled By: mondaychen

fbshipit-source-id: cf469b96a5220966718270e43e3f0503e144acf3
eagle2722 added a commit to eagle2722/Recoil that referenced this issue Sep 21, 2024
@eagle2722
Update RecoilRootProps type for React 18 types (#1718)
394b14d 
Summary:
Fixes facebookexperimental/Recoil#1717

Since types/react v18, Implicit `children` was removed from `React.FC`. This change works for types/react v18 and earlier.
DefinitelyTyped/DefinitelyTyped#56210

Pull Request resolved: facebookexperimental/Recoil#1718

Reviewed By: drarmstr

Differential Revision: D35501855

Pulled By: mondaychen

fbshipit-source-id: cf469b96a5220966718270e43e3f0503e144acf3
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
TypeScript / Flow
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update RecoilRootProps type for React 18 types dqn/Recoil
4 participants
@hcharley @faradaytrs @drarmstr @tpatalas