-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Conversation
This pull request was exported from Phabricator. Differential Revision: D32572832 |
6bf1a42
to
da66d50
Compare
This pull request was exported from Phabricator. Differential Revision: D32572832 |
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: D32572832 fbshipit-source-id: 078b60282cf99f5bfd34ef7a99efb643b4696c6c
This pull request was exported from Phabricator. Differential Revision: D32572832 |
da66d50
to
427f9de
Compare
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: D32572832 fbshipit-source-id: 1574aa537a1e1f812d7dcec0a041999464c9f171
427f9de
to
99f19fd
Compare
This pull request was exported from Phabricator. Differential Revision: D32572832 |
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: c2db08649f48a1702dce923f25a68beb4397f3fc
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 90e4d2139acb1279fd2255278fa91d8769dd70a0
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 788d31eb0aae7831f7b9fca98bfcb4a6de50d245
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 73e18147c18a0540abfd253fd48f1c2355075fd6
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b46ce89dbb63d8da5234a318c1c0d40160f4dfe8
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 722fc3e0964afb273feb5614f9c43966e2db0f82
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 930c0eb079d85bcd90863d0526445d1d1af0255f
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 666cd92192baa3c6ab2920e5dad7d33dbb83f325
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 670cc261379d0774d2b042b8c9e68506f4d674f4
This pull request was exported from Phabricator. Differential Revision: D32572832 |
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: D32572832 fbshipit-source-id: a1996e0bba09e8962f6a7874959e2eafedbdef29
99f19fd
to
af26d96
Compare
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 9bcf59927f678673ea3e602a6608fc57cac931e8
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 0f43d5e41f49340c763b448dc56f0991a31cdafa
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 020622c27cdf1b7f4e3686e776e2d702e255d183
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b9227e45f77269853e288d95aafc5e2d3680c478
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b60dac11bdc23df2aa9f8e54b9d249ca15c0cf85
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 3b208cb76b926b18cf2c6cfdcb0e7773618f78d6
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: d008b8b446a55943ae48da19cd1e52588cf74074
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 4731b5017cbad512943a43777af54687ae736043
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 0bc894f1f4a0e17d6c28e5dfe36a5b7af7d2f639
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b947222759bfae28cd197ea458d893635e04c31e
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Reviewed By: davidmccabe Differential Revision: D32572832 fbshipit-source-id: 3b2ce46d5d66ecec9e2520adadadb7a38663a099
af26d96
to
ae9e0be
Compare
This pull request was exported from Phabricator. Differential Revision: D32572832 |
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 272732b14c0a1ec7e6b2c473a7c0b1bd3147683a
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: 66835e918e1c9a20181986686587ebae864dac29
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Reviewed By: davidmccabe Differential Revision: D32572832 fbshipit-source-id: a4acc5a332b13032bb861e00d1d951752ab214fa
ae9e0be
to
62971a2
Compare
This pull request was exported from Phabricator. Differential Revision: D32572832 |
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: fb68aa93291e014e4911cf10d6ad3e434416cbe4
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b651677265f812599d6d7fc31191121b33db55a4
Summary: Pull Request resolved: facebookexperimental#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Differential Revision: https://www.internalfb.com/diff/D32572832?entry_point=27 fbshipit-source-id: b0a38a26df9e971726d11cafcef9203b75393238
@drarmstr what happened here, was this merged, closed or pushed out, I have issues with strict mode |
Yes, this was merged; it just wasn't released in a new NPM package yet. You can use the nightly branch until then. |
@drarmstr couldn't get the nightly to install, I guess I'll have to wait for the release. I'm essentially getting a screen flash/reload when recoil initially loads. |
Summary: Pull Request resolved: facebookexperimental/Recoil#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Reviewed By: davidmccabe Differential Revision: D32572832 fbshipit-source-id: 0ad1a4a68652e3bb4c7a97a985a5b87a7883743b
Summary: Pull Request resolved: facebookexperimental/Recoil#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Reviewed By: davidmccabe Differential Revision: D32572832 fbshipit-source-id: 0ad1a4a68652e3bb4c7a97a985a5b87a7883743b
Summary: Pull Request resolved: facebookexperimental/Recoil#1444 Fix Recoil for React strict mode which runs effects multiple times. * Now atoms are re-initialized after the effect cleanup handler has cleaned them up. Support case if the store changes with the re-mounting, such as changing the fallthrough prop. * The Batcher will reenable the notification mechanism after it was disabled on unmounting to avoid late async updates from trying to re-render. * Audit all other useEffect() calls except for `useRecoilInterface()` and dev tools `<Connector>` Inspired from D24722151 Reviewed By: davidmccabe Differential Revision: D32572832 fbshipit-source-id: 0ad1a4a68652e3bb4c7a97a985a5b87a7883743b
Fix Recoil for React strict mode which runs effects multiple times:
Inspired from D24722151
Differential Revision: D32572832