This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Better fix for StrictMode #1473
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D32751941 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Dec 6, 2021
Summary: Pull Request resolved: facebookexperimental#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Differential Revision: D32751941 fbshipit-source-id: b4810d6b125d63621223a159d5282dbf5584c45d
drarmstr
force-pushed
the
export-D32751941
branch
from
ff4b05a to
fed1607
Compare
|
This pull request was exported from Phabricator. Differential Revision: D32751941 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Dec 8, 2021
Summary: Pull Request resolved: facebookexperimental#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Reviewed By: davidmccabe Differential Revision: D32751941 fbshipit-source-id: 2ebea0aba135f9194715a447170ae692815ece1d
|
This pull request was exported from Phabricator. Differential Revision: D32751941 |
drarmstr
force-pushed
the
export-D32751941
branch
from
fed1607 to
e5f119d
Compare
Summary: Pull Request resolved: facebookexperimental#1451 Automate testing React StrictMode and beef up tests to pass or skip in that environment. NOTE: Garbage collection tests are currently failing with atoms being retained when they shouldn't be in StrictMode Differential Revision: https://www.internalfb.com/diff/D32605982?entry_point=27 fbshipit-source-id: 4b99c388b088d3360ef1658fe53aaacf324cdd9a
Summary: Pull Request resolved: facebookexperimental#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Reviewed By: davidmccabe Differential Revision: D32751941 fbshipit-source-id: c163749c5ee0df3371c1c56051b90640b92baf79
|
This pull request was exported from Phabricator. Differential Revision: D32751941 |
drarmstr
force-pushed
the
export-D32751941
branch
from
e5f119d to
9bbb0b9
Compare
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Reviewed By: davidmccabe Differential Revision: D32751941 fbshipit-source-id: 7b36a6c6ed344cc899b48d649ea9dafff5af004c
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Reviewed By: davidmccabe Differential Revision: D32751941 fbshipit-source-id: 7b36a6c6ed344cc899b48d649ea9dafff5af004c
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1473 A better fix for React StrictMode. Instead of maintaining a ref in `<RecoilRoot>` for the set of atoms to re-initialize we will just keep the atoms in `knownAtoms` even when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already in `knownAtoms`. We also have to be careful when using an initialized atom in a `Snapshot` that it does not try to re-initialize. Reviewed By: davidmccabe Differential Revision: D32751941 fbshipit-source-id: 7b36a6c6ed344cc899b48d649ea9dafff5af004c
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: A better fix for React StrictMode. Instead of maintaining a ref in
<RecoilRoot>for the set of atoms to re-initialize we will just keep the atoms inknownAtomseven when they are cleaned up. This way we maintain the set of known atoms we need to re-initialize. However, we have to be careful to ensure the we actually re-initialize the atom when the effect runs again, even if it is already inknownAtoms. We also have to be careful when using an initialized atom in aSnapshotthat it does not try to re-initialize.Differential Revision: D32751941