This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Enable atoms to be initialized to a Promise #1681
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34975767 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D34975767 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Mar 25, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: D34975767 fbshipit-source-id: 8b57ddd26e3e521bb7dfb37e947a6d7bc1399c63
drarmstr
force-pushed
the
export-D34975767
branch
from
f370d73 to
c6c0a35
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34975767 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Mar 25, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: D34975767 fbshipit-source-id: 784443175018133b37894e1daab4e53338a88685
drarmstr
force-pushed
the
export-D34975767
branch
from
c6c0a35 to
7acb985
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34975767 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Mar 25, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: D34975767 fbshipit-source-id: 16a70f6b1087cf9258039dec862f4f1773c6b640
drarmstr
force-pushed
the
export-D34975767
branch
from
7acb985 to
73e18a5
Compare
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: D34975767 fbshipit-source-id: 29b52bb635ad17793c32714670a3c33d9bd25b20
drarmstr
force-pushed
the
export-D34975767
branch
from
73e18a5 to
bfa979a
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34975767 |
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Apr 8, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: https://www.internalfb.com/diff/D34975767?entry_point=27 fbshipit-source-id: 7846112e86a9a4af82a4e76da06944ec02c9f54e
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Apr 8, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: https://www.internalfb.com/diff/D34975767?entry_point=27 fbshipit-source-id: 36fc7d893fa4146d9f2ebcf95aef5d9ad715d9d7
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Apr 15, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: https://www.internalfb.com/diff/D34975767?entry_point=27 fbshipit-source-id: 9dcc6741d01023f3495fa79f393d712a58b6f799
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Apr 15, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: https://www.internalfb.com/diff/D34975767?entry_point=27 fbshipit-source-id: ac2ea59cea4c2b719c22ea77d392ab7d5d73eac4
drarmstr
added a commit
to drarmstr/Recoil
that referenced
this pull request
Apr 15, 2022
…xperimental#1681) Summary: Pull Request resolved: facebookexperimental#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Differential Revision: https://www.internalfb.com/diff/D34975767?entry_point=27 fbshipit-source-id: a95f45ec45e1a36758fb18f50f235c2b0e08b0c8
AlexGuz23
pushed a commit
to AlexGuz23/Recoil
that referenced
this pull request
Nov 3, 2022
Summary: Pull Request resolved: facebookexperimental/Recoil#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Reviewed By: noritheduck Differential Revision: D34975767 fbshipit-source-id: 45bb3274646ef8ebb31d0390ee34300a57bdcd2e
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
Summary: Pull Request resolved: facebookexperimental/Recoil#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Reviewed By: noritheduck Differential Revision: D34975767 fbshipit-source-id: 45bb3274646ef8ebb31d0390ee34300a57bdcd2e
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
Summary: Pull Request resolved: facebookexperimental/Recoil#1681 Minor completeness for the API to allow atoms to be initialized to `Promise` types by wrapping them, similar to atom defaults. To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness and for future work to support async atoms Reviewed By: noritheduck Differential Revision: D34975767 fbshipit-source-id: 45bb3274646ef8ebb31d0390ee34300a57bdcd2e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Minor completeness for the API to allow atoms to be initialized to
Promisetypes by wrapping them, similar to atom defaults.To properly allow Promises and such as atom values we also need the ability to set atoms to Promises. The point of this diff is to provide completeness for future work to support async atoms
Differential Revision: D34975767