This repository has been archived by the owner on Jan 1, 2025. It is now read-only.
Workaround React renderers without useSyncExternalStore() support #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D39329856 |
…ort (facebookexperimental#2001) Summary: Pull Request resolved: facebookexperimental#2001 Recoil will attemp to detect if `useSyncExternalStore()` is supported before calling it. However, sometimes the host environment supports it but creates additional React renderers, such as with `react-three-fiber`, which do not. Since React goes through a proxy dispatcher we can't simply check if `useSyncExternalStore()` is defined. Thus, this workaround will catch the situation and fallback to using `useState()` and `useEffect()`. Differential Revision: D39329856 fbshipit-source-id: 564cd38392902fbd56c8a1b10cb99450bfe282a4
|
This pull request was exported from Phabricator. Differential Revision: D39329856 |
drarmstr
force-pushed
the
export-D39329856
branch
from
92962fa to
2e5126c
Compare
snipershooter0701
pushed a commit
to snipershooter0701/Recoil
that referenced
this pull request
Mar 5, 2023
…ort (#2001) Summary: Pull Request resolved: facebookexperimental/Recoil#2001 Recoil will attemp to detect if `useSyncExternalStore()` is supported before calling it. However, sometimes the host environment supports it but creates additional React renderers, such as with `react-three-fiber`, which do not. Since React goes through a proxy dispatcher we can't simply check if `useSyncExternalStore()` is defined. Thus, this workaround will catch the situation and fallback to using `useState()` and `useEffect()`. Reviewed By: habond Differential Revision: D39329856 fbshipit-source-id: 6e4e853d4f3d758b4171ac49cab9fbb1170f66b4
eagle2722
added a commit
to eagle2722/Recoil
that referenced
this pull request
Sep 21, 2024
…ort (#2001) Summary: Pull Request resolved: facebookexperimental/Recoil#2001 Recoil will attemp to detect if `useSyncExternalStore()` is supported before calling it. However, sometimes the host environment supports it but creates additional React renderers, such as with `react-three-fiber`, which do not. Since React goes through a proxy dispatcher we can't simply check if `useSyncExternalStore()` is defined. Thus, this workaround will catch the situation and fallback to using `useState()` and `useEffect()`. Reviewed By: habond Differential Revision: D39329856 fbshipit-source-id: 6e4e853d4f3d758b4171ac49cab9fbb1170f66b4
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Recoil will attemp to detect if
useSyncExternalStore()is supported before calling it. However, sometimes the host environment supports it but creates additional React renderers, such as withreact-three-fiber, which do not. Since React goes through a proxy dispatcher we can't simply check ifuseSyncExternalStore()is defined. Thus, this workaround will catch the situation and fallback to usinguseState()anduseEffect().Differential Revision: D39329856