Skip to content
This repository has been archived by the owner on Jan 1, 2025. It is now read-only.

Conversation

leonbe02
Copy link

@leonbe02 leonbe02 commented Nov 4, 2022

Resolves #2082

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 4, 2022
@drarmstr drarmstr added the bug Something isn't working label Nov 5, 2022
@facebook-github-bot
Copy link
Contributor

@drarmstr has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@leonbe02
Copy link
Author

leonbe02 commented Nov 7, 2022

Btw, the tests that are failing in the build are the same tests that are failing on the main branch so I don't think they are related to my changes.

@drarmstr
Copy link
Contributor

drarmstr commented Nov 8, 2022

Btw, the tests that are failing in the build are the same tests that are failing on the main branch so I don't think they are related to my changes.

Yeah, no worries about that, it's being fixed in another PR.

@leonbe02
Copy link
Author

leonbe02 commented Nov 8, 2022

Btw, the tests that are failing in the build are the same tests that are failing on the main branch so I don't think they are related to my changes.

Yeah, no worries about that, it's being fixed in another PR.

Should I just close this PR then?

@drarmstr
Copy link
Contributor

drarmstr commented Nov 9, 2022

Btw, the tests that are failing in the build are the same tests that are failing on the main branch so I don't think they are related to my changes.

Yeah, no worries about that, it's being fixed in another PR.

Should I just close this PR then?

I meant the failure was fixed with another commit. Working on landing this PR now.

Gumichocopengin8 pushed a commit to Gumichocopengin8/Recoil that referenced this pull request Nov 10, 2022
…g SSR (facebookexperimental#2086)

Summary:
Resolves facebookexperimental#2082

Pull Request resolved: facebookexperimental#2086

Reviewed By: wd-fb

Differential Revision: D41054948

Pulled By: drarmstr

fbshipit-source-id: eb421deb5a84e9ff9390a1a8d88b28c720765cb1
@facebook-github-bot
Copy link
Contributor

@leonbe02 has updated the pull request. You must reimport the pull request before landing.

@andreisoare
Copy link

Looking forward to see this land, as it blocks my upgrade to Next.JS 13.

@facebook-github-bot
Copy link
Contributor

@leonbe02 has updated the pull request. You must reimport the pull request before landing.

@leonbe02
Copy link
Author

@drarmstr Are you able to re-import the PR? I just rebased it with main which flags it as needing to be re-imported.

@leonbe02
Copy link
Author

Nevermind, it looks like my commit already got imported into main somehow. Should I close this PR then @drarmstr ?

@leonbe02
Copy link
Author

leonbe02 commented Dec 5, 2022

Closing since this change was imported into main by @drarmstr

@leonbe02 leonbe02 closed this Dec 5, 2022
@leonbe02 leonbe02 deleted the bugfix/adding-undefined-check-on-unstable-batched-updates-to-support-ssr-with-next branch December 5, 2022 18:49
snipershooter0701 pushed a commit to snipershooter0701/Recoil that referenced this pull request Mar 5, 2023
…g SSR (#2086)

Summary:
Resolves facebookexperimental/Recoil#2082

Pull Request resolved: facebookexperimental/Recoil#2086

Reviewed By: wd-fb

Differential Revision: D41054948

Pulled By: drarmstr

fbshipit-source-id: eb421deb5a84e9ff9390a1a8d88b28c720765cb1
eagle2722 added a commit to eagle2722/Recoil that referenced this pull request Sep 21, 2024
…g SSR (#2086)

Summary:
Resolves facebookexperimental/Recoil#2082

Pull Request resolved: facebookexperimental/Recoil#2086

Reviewed By: wd-fb

Differential Revision: D41054948

Pulled By: drarmstr

fbshipit-source-id: eb421deb5a84e9ff9390a1a8d88b28c720765cb1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SSR] Recoil doesn't work server side with Next.js 13
4 participants