Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataPartition] Support paritioning if results. #15

Merged
merged 2 commits into from
Jan 9, 2025
Merged

[DataPartition] Support paritioning if results. #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c8e02d
[DataPartition] Support paritioning if results.
htyu Dec 20, 2024
b6c6f84
Clean up dead if results.
htyu Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
65 changes: 57 additions & 8 deletions lib/Dialect/TritonGPU/Transforms/WSDataPartition.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,12 +168,11 @@ void getForwardSliceToPartition(Value root, unsigned dim, int sliceSize,
if (op->getNumResults() > 0)
seen.insert(op->getResult(0));
if (auto yieldOp = dyn_cast<scf::YieldOp>(op)) {
if (auto forOp = dyn_cast<scf::ForOp>(yieldOp->getParentOp())) {
for (OpOperand &operand : yieldOp->getOpOperands()) {
if (seen.count(operand.get())) {
queue.push_back(forOp->getResult(operand.getOperandNumber()));
forwardSlice.insert(forOp);
}
auto parentOp = yieldOp->getParentOp();
for (OpOperand &operand : yieldOp->getOpOperands()) {
if (seen.count(operand.get())) {
queue.push_back(parentOp->getResult(operand.getOperandNumber()));
forwardSlice.insert(parentOp);
}
}
}
Expand Down Expand Up @@ -543,7 +542,56 @@ Operation *sliceOp(Operation *op, int offset,
mappings.map(regionArg, newRegionArg);
reverseMappings.map(newRegionArg, regionArg);
}

} else if (auto ifOp = dyn_cast<scf::IfOp>(op)) {
// Slice the yield op and update if results
auto thenYieldOp = ifOp.thenYield();
auto elseYieldOp = ifOp.elseYield();
auto newThenYieldOp = sliceOp(thenYieldOp, offset, builder, mappings,
reverseMappings, partitionScheme);
sliceOp(elseYieldOp, offset, builder, mappings, reverseMappings,
partitionScheme);
assert(newThenYieldOp->getNumOperands() > ifOp->getNumResults() &&
"no need to slice if op");
// Clone ifOp with updated results but re-use the original regions.
builder.setInsertionPoint(op);
SmallVector<Type, 4> newResultTypes;
for (auto thenResult : thenYieldOp.getResults()) {
newResultTypes.push_back(thenResult.getType());
}
auto newIfOp = builder.create<scf::IfOp>(ifOp.getLoc(), newResultTypes,
ifOp.getCondition());
// Move the original regions to the cloned operation.
newIfOp.getThenRegion().takeBody(ifOp.getThenRegion());
newIfOp.getElseRegion().takeBody(ifOp.getElseRegion());
newOp = newIfOp;
newIfOp->setAttrs(ifOp->getAttrs());
partitionScheme.ops.insert(newIfOp);
ifOp->setAttr("to_be_removed", builder.getUnitAttr());

// Replace ifOp with newIfOp
for (unsigned i = 0; i < ifOp.getNumResults(); ++i)
ifOp.getResult(i).replaceAllUsesWith(newIfOp.getResult(i));

// Map if results based on the mapping for yield
for (auto &v : thenYieldOp->getOpOperands()) {
auto newV = mappings.lookupOrNull(v.get());
if (newV) {
int operandIndex = v.getOperandNumber();
// find the corresponding operand index of newV in newYieldOp
int newOperandIndex = -1;
for (int i = 0; i < newThenYieldOp->getNumOperands(); ++i) {
if (newThenYieldOp->getOperand(i) == newV) {
newOperandIndex = i;
break;
}
}
assert(newOperandIndex >= 0 && "newV not found in newYieldOp");
auto newResult = newIfOp.getResult(operandIndex);
auto newSlicedResult = newIfOp.getResult(newOperandIndex);
mappings.map(newResult, newSlicedResult);
reverseMappings.map(newSlicedResult, newResult);
}
}
} else if (auto yieldOp = dyn_cast<scf::YieldOp>(op)) {
int num = yieldOp.getNumOperands();
for (int i = 0; i < num; i++) {
Expand All @@ -565,7 +613,7 @@ Operation *sliceOp(Operation *op, int offset,
newOp->walk(
[&](Operation *childOp) { setAsyncTaskIds(childOp, sliceTaskIds); });
} else {
llvm_unreachable("unsupported value type");
llvm_unreachable("unsupported op type");
}

LLVM_DEBUG({
Expand Down Expand Up @@ -668,6 +716,7 @@ void partitionTasks(triton::FuncOp &funcOp) {
RewritePatternSet cleanUpPatterns(funcOp.getContext());
populateForOpDeadArgumentElimination(cleanUpPatterns);
scf::ForOp::getCanonicalizationPatterns(cleanUpPatterns, funcOp.getContext());
scf::IfOp::getCanonicalizationPatterns(cleanUpPatterns, funcOp.getContext());
if (applyPatternsAndFoldGreedily(funcOp, std::move(cleanUpPatterns))
.failed()) {
llvm_unreachable("failed to clean up");
Expand Down
Loading