handle py2/py3 print statement vs function better (via user configurable option) #123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
thatch
reviewed
Mar 20, 2020
thatch
reviewed
Mar 20, 2020
| ``` | ||
|
|
||
| * `*paths` - Accepts either individual file or directory paths (relative to the current | ||
| working directory), or lists of paths, for any positional argument given. | ||
| Defaults to the current working directory if no arguments given. | ||
|
|
||
| * `*filename_matcher*` - A callback which returns whether a given filename is | ||
| * `python_version` - The 'major' python version of the files to be refactored, i.e. `2` |
There was a problem hiding this comment.
Can you add asterisks back on the param names please?
There was a problem hiding this comment.
sorry, I thought maybe they were intended as bold formatting but they display as literal asterisks (and it's not an *args param)
will put them back
also I will reorder docs and code to put my new arg after the existing one, that would be safer
thatch
reviewed
Mar 20, 2020
… Query arg after existing ones
|
Thank you! |
|
Thanks so much for merging! Do you have an idea when the next PyPI release will be? |
|
I hope soon, but we ought to do some manual testing on windows first -- this release ought to work there (in single process mode) and I'd like to mention that in the release notes if so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #119
this allows Bowler to refactor py2 files containing
printstatements