Skip to content

Commit

Permalink
Back out "[antlir2][buck] strip platform config from rpm snapshot rules"
Browse files Browse the repository at this point in the history
Summary:
Original commit changeset: 5ecd0a25d784

Original Phabricator Diff: D68562713

Breaking `fast-snapshot` and I don't really know why

Test Plan:
testhard
```
[vmagro@92357.od /data/sandcastle/boxes/fbsource (d825ae2b7)]$ buck bxl fbcode//mode/opt fbcode//antlir/antlir2/package_managers/dnf/snapshot/facebook/fast_snapshot/fast_snapshot.bxl:universe_to_json
buck-out/v2/gen-bxl/fbcode/b50fd50c6a3e2a68/antlir/antlir2/package_managers/dnf/snapshot/facebook/fast_snapshot/fast_snapshot.bxl/__universe_to_json__fc092b66ef0e1e93__/universe.json
BXL SUCCEEDED

[vmagro@92357.od /data/sandcastle/boxes/fbsource (d825ae2b7)]$ jq < buck-out/v2/gen-bxl/fbcode/b50fd50c6a3e2a68/antlir/antlir2/package_managers/dnf/snapshot/facebook/fast_snapshot/fast_snapshot.bxl/__universe_to_json__fc092b66ef0e1e93__/universe.json '.rpms | length'
376078
```

Reviewed By: naveedgol

Differential Revision: D68604934

fbshipit-source-id: fbac1c97eb296139f4965968eacd79bf2a9e8700
  • Loading branch information
vmagro authored and facebook-github-bot committed Jan 24, 2025
1 parent 429034b commit 6e300ce
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def _strip_configuration_transition_impl(
configuration = ConfigurationInfo(constraints = {}, values = {}),
)

strip_configuration_transition = transition(
_strip_configuration_transition = transition(
impl = _strip_configuration_transition_impl,
refs = {},
)
Expand All @@ -46,7 +46,7 @@ def _strip_configuration_impl(ctx: AnalysisContext) -> list[Provider]:
strip_configuration_alias = rule(
impl = _strip_configuration_impl,
attrs = {
"actual": attrs.transition_dep(cfg = strip_configuration_transition),
"actual": attrs.transition_dep(cfg = _strip_configuration_transition),
"labels": attrs.list(attrs.string(), default = []),
},
)

0 comments on commit 6e300ce

Please sign in to comment.