crypto: Fix compilation with no ChaCha20 #27
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you create a FIZZ_HAS_CHACHA define or similar and based the other checks (like fizz/fizz/client/FizzClientContext.h Line 226 in bc80449 |
|
This looks like it would be better suited for inclusion in folly's portability header. On the other hand, a git grep of the code base also shows three of these: |
facebook-github-bot
pushed a commit
to facebook/folly
that referenced
this pull request
Jun 1, 2019
Summary: This can be used to check if ChaCha20 is available for use. Signed-off-by: Rosen Penev <rosenp@gmail.com> related: facebookincubator/fizz#27 Pull Request resolved: #1146 Reviewed By: knekritz Differential Revision: D15583706 Pulled By: yfeldblum fbshipit-source-id: 1195d623098018992811cd7d6cef72e2366ace19
ChaCha20 can be compile time disabled. Check for it. Using folly's define for this.
|
I pushed a new version. I checked every place in the fizz source that checks for ChaCha20 compatibility and replaced it with the new define. |
There was a problem hiding this comment.
@knekritz has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 16, 2020
Summary: Pull Request resolved: facebook/sapling#27 Pull Request resolved: facebookexperimental/rust-shed#9 Original diffs: D22417488 (1adf0d7), D22528869 (9176fae) Reviewed By: markbt Differential Revision: D22571972 fbshipit-source-id: c6f013565680a757b642dd79e647207fce3351ec
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ChaCha20 can be compile time disabled. Check for it.