Skip to content

Commit

Permalink
fb-util: Include Executor.cpp
Browse files Browse the repository at this point in the history
On systems with LD_BIND_NOW set or ghc with RTLD_DEFAULT linking enable,
compilaton of fb-util fails due to missing symbol
`common_hs_releaseGlobalCPUExecutor`. This is defined in Executor.cpp,
so we need to include it into the compilation.

Now I tried to add Utils/Executor.cpp and still got the errors. When
I moved the file to cpp/Executor.cpp and included it, it worked. Now I
have no clue why that is, and i tried to clean build artifacts but still
had issues when Executor.cpp is not in cpp/. So I left it, without
actually knowing _why_ this is.
  • Loading branch information
dsp committed Jul 12, 2022
1 parent 365900d commit 83ed60e
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 0 deletions.
File renamed without changes.
1 change: 1 addition & 0 deletions common/util/fb-util.cabal
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ library
cpp/HsStruct.cpp
cpp/IOBuf.cpp
cpp/EventBaseDataplane.cpp
cpp/Executor.cpp
Util/AsanAlloc.cpp
-- Util/GFlags.cpp

Expand Down

0 comments on commit 83ed60e

Please sign in to comment.