Skip to content

Commit

Permalink
Fix ExceptionTests.Verify after enabling -Waddress flag
Browse files Browse the repository at this point in the history
Summary:
-Waddress is about to be enabled, and it will cause a compilation error:
```
fbcode/dwio/alpha/common/tests/ExceptionTests.cpp:147:13: error: result of comparison against a string literal is unspecified (use an explicit string comparison function instead) [-Werror,-Wstring-compare]
        "a" == "b",
        ~~~ ^
```

Differential Revision: D55153584
  • Loading branch information
Daniel Munoz authored and facebook-github-bot committed Mar 20, 2024
1 parent c9a81de commit bd42183
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions dwio/alpha/common/tests/ExceptionTests.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ TEST(ExceptionTests, Assert) {
TEST(ExceptionTests, Verify) {
try {
ALPHA_VERIFY_EXTERNAL(
"a" == "b",
1 == 2,
LocalFileSystem,
alpha::error_code::NotSupported,
true,
Expand All @@ -156,7 +156,7 @@ TEST(ExceptionTests, Verify) {
__FILE__,
"",
"TestBody",
"\"a\" == \"b\"",
"1 == 2",
"error message3",
"EXTERNAL",
"NOT_SUPPORTED",
Expand Down

0 comments on commit bd42183

Please sign in to comment.