Combine multiple layers of dictionaries when writing flatmap column #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
5b55a5f to
be71e51
Compare
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
be71e51 to
e692c24
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
e692c24 to
b465651
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
b465651 to
1eed731
Compare
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
1eed731 to
a0eaa22
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
a0eaa22 to
c0bfcc5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
c0bfcc5 to
4723ffd
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
4723ffd to
68d9a14
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
68d9a14 to
5c1e610
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 12, 2024
…acebookincubator#114) Summary: Pull Request resolved: facebookincubator#114 The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
5c1e610 to
568d543
Compare
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 13, 2024
…acebookincubator#114) Summary: The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
568d543 to
0613bf6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
Yuhta
added a commit
to Yuhta/nimble
that referenced
this pull request
Dec 13, 2024
…acebookincubator#114) Summary: The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
0613bf6 to
c6eea1c
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
…acebookincubator#114) Summary: The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with `ArrayWithOffsets`. Reviewed By: xiaoxmeng, HuamengJiang Differential Revision: D66992657
Yuhta
force-pushed
the
export-D66992657
branch
from
c6eea1c to
d9d1e92
Compare
|
This pull request was exported from Phabricator. Differential Revision: D66992657 |
|
This pull request has been merged in 2fa1587. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The current writer cannot handle dictionary around flat map column. Fix this case by push the dictionary to flat map values, so they can be potentially encoded with
ArrayWithOffsets.Differential Revision: D66992657