Skip to content
This repository has been archived by the owner on Dec 1, 2024. It is now read-only.

Fix: wrong cpe version match #214

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mashiro01
Copy link

We came across a scene like this

the cpe is like: cpe:/a:xxx:yyy:x.y.z, but the version should always start with a number, so it should not match any cve. But after padding 0 to left, the version is became to 0x.y.z, so with go's strings.compare, it will match any cpe version which starts with 0 and has versionendincluding
image

@facebook-github-bot
Copy link

Hi @mashiro01!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Jan 16, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants