This repository has been archived by the owner on Apr 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 167
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add support for consuming chroma sampling 4:1:1 and 4:4:0
Summary: Adding support for 4:1:1 and 4:4:0 sub-sampling as discussed in #8 **Test plan** Followed the reproduction steps from the file with a file captured in 4:1:1 as input. Before: ``` SpectrumException{ name='decompressor_unexpected_chroma_sampling', message='decompressor_unexpected_chroma_sampling', location='image::ChromaSamplingMode facebook::spectrum::plugins::jpeg::LibJpegDecompressor::_chromaSamplingMode():103', ... ``` After: ``` SpectrumResult{ ruleName='base', inputImageSpecification=ImageSpecification{size=ImageSize{width=1431, height=2688}, format=jpeg, pixelSpecification=ImagePixelSpecification{colorModel=RGB, bytesPerPixel=3, alphaInfo=NONE, componentsOrder=NATURAL}, orientation=UP, chromaSamplingMode=S411, metadata=ImageMetadata{}}, outputImageSpecification=ImageSpecification{size=ImageSize{width=533, height=1000}, format=jpeg, pixelSpecification=ImagePixelSpecification{colorModel=RGB, bytesPerPixel=3, alphaInfo=NONE, componentsOrder=NATURAL}, orientation=UP, chromaSamplingMode=S420, metadata=ImageMetadata{}}, totalBytesRead=1854587, totalBytesWritten=58664 } ``` Reviewed By: cuva Differential Revision: D13233286 fbshipit-source-id: 408cf5f74a6c1dedefa35b92449923e3c73b8dc6
- Loading branch information
1 parent
8a67810
commit d36ba0e
Showing
10 changed files
with
60 additions
and
2 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters