Move all dumps to cloudpickle #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
@gwenzek do you remember any reason why we used the standard pickle for dumping results? That may just have been historical, and we would be better off with cloudpickle all along |
jrapin
commented
Oct 22, 2020
|
LGTM. I don't think there are good reason to use pickle instead of cloudpickle for return. Should we cut a bug fix release ? |
I think that would help hydra people yes |
|
I think it was just an oversight. @LowikC may remember ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces facebookresearch/hydra#1083 as a test and fixes it by moving all dumps to cloudpickle.