Simple functions type analysis. #1041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D34226886 |
laithsakka
commented
Feb 15, 2022
|
This pull request was exported from Phabricator. Differential Revision: D34226886 |
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: facebookincubator#1041 Add an analysis to the simple function types to extract information that is needed in the next diff to assign priorities to signatures. The recursion that used to convert the types to their string representation is updated to a general analysis that collects other information as well. Unit tests added in the diff. Differential Revision: D34226886 fbshipit-source-id: ba67d92b578da40a0ee1639018010b74c32f0a91
laithsakka
force-pushed
the
export-D34226886
branch
from
f96d6da to
222b7d9
Compare
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: facebookincubator#1041 Add an analysis to the simple function types to extract information that is needed in the next diff to assign priorities to signatures. The recursion that used to convert the types to their string representation is updated to a general analysis that collects other information as well. Unit tests added in the diff. Differential Revision: D34226886 fbshipit-source-id: 3b37984bfe12b5d633d2f299062e23653e95cfb9
|
This pull request was exported from Phabricator. Differential Revision: D34226886 |
laithsakka
force-pushed
the
export-D34226886
branch
from
222b7d9 to
9654e81
Compare
|
fix typos in comments |
kevinwilfong
approved these changes
Feb 15, 2022
velox/core/SimpleFunctionMetadata.h
Outdated
| // E.g: Variadic<T> or Variadic<Array<T1>>. | ||
| bool hasVariadicOfGeneric = false; | ||
|
|
||
| // The number of types that are not generic, nor variadic. |
There was a problem hiding this comment.
nit: The number of types that are neither generic, nor variadic.
laithsakka
added a commit
to laithsakka/velox
that referenced
this pull request
Feb 15, 2022
Summary: Pull Request resolved: facebookincubator#1041 Add an analysis to the simple function types to extract information that is needed in the next diff to assign priorities to signatures. The recursion that used to convert the types to their string representation is updated to a general analysis that collects other information as well. Unit tests added in the diff. Reviewed By: kevinwilfong Differential Revision: D34226886 fbshipit-source-id: 8383482fc61c65fddc90b0027b1f68f6602fa54e
laithsakka
force-pushed
the
export-D34226886
branch
from
9654e81 to
5dd1750
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34226886 |
Summary: Pull Request resolved: facebookincubator#1041 Add an analysis to the simple function types to extract information that is needed in the next diff to assign priorities to signatures. The recursion that used to convert the types to their string representation is updated to a general analysis that collects other information as well. Unit tests added in the diff. Reviewed By: kevinwilfong Differential Revision: D34226886 fbshipit-source-id: ee821ef18f134695de5389a786f2059dba765b88
laithsakka
force-pushed
the
export-D34226886
branch
from
5dd1750 to
a6ebad5
Compare
|
This pull request was exported from Phabricator. Differential Revision: D34226886 |
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Mar 17, 2023
* # This is a combination of 2 commits. # This is the 1st commit message: add unit-test for VeloxSplitter # This is the commit message #2: # update ut * add unit-test for VeloxSplitter --------- Co-authored-by: zuochunwei <zuochunwei@meituan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Add an analysis to the simple function types to extract information that is needed
in the next diff to assign priorities to signatures.
The recursion that used to convert the types to their string representation is updated
to a general analysis that collects other information as well.
Unit tests added in the diff.
Differential Revision: D34226886