Fix velox_dwio_parquet_reader_benchmark build on Ubuntu #10648
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
majetideepak
force-pushed
the
fix-benchmark
branch
from
227796f to
a911731
Compare
majetideepak
changed the title
assignUser
approved these changes
Aug 2, 2024
majetideepak
added
the
ready-to-merge
|
@kagamiori has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
bdice
approved these changes
Aug 2, 2024
|
@kagamiori merged this pull request in 07bfc61. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
This was referenced Aug 6, 2024
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 6, 2024
Summary: For some reason the linux debug build has started to fail because it get's oom killed during linking: https://github.com/facebookincubator/velox/actions/runs/10259255187/job/28383420958#step:7:6891 I am not sure if the addition of parquet in #10648 is to blame, in that PR the job did not fail. Pull Request resolved: #10671 Reviewed By: kevinwilfong Differential Revision: D60841583 Pulled By: kagamiori fbshipit-source-id: f3d4a679baf2739f8ff316b535377036527be07d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #10323