Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Enable Parquet E2E filter tests on decimal type #11602

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Enable Parquet E2E filter tests on decimal type #11602

wants to merge 2 commits into from
+19 −7

Conversation

rui-mo
Copy link
Collaborator

@rui-mo rui-mo commented Nov 20, 2024 •
edited
Loading

  1. Fixes 'BatchMaker::createVectorTypeKind::BIGINT' to ensure decimal vector
    can be generated.
  2. Fixes 'testRowGroupSkip' for short decimal. Clarifies that row group skip based
    on column statistics for decimal type is not currently supported.
  3. Supports 'testInt128' in IsNull filter.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 20, 2024
@rui-mo rui-mo changed the title Enable Parquet E2E filter tests on decimal type fix: Enable Parquet E2E filter tests on decimal type Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit bcdb766
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/673da6ad7a6e0200084d7059

@rui-mo rui-mo force-pushed the wip_part_decimal branch 2 times, most recently from 0ff89b3 to bcdb766 Compare November 20, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majetideepak majetideepak Awaiting requested review from majetideepak majetideepak is a code owner

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rui-mo @facebook-github-bot