Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hdfs): Use available port for HdfsMiniCluster #11996

Closed
wants to merge 5 commits into from

Conversation

majetideepak
Copy link
Collaborator

@majetideepak majetideepak commented Dec 31, 2024

Fixes: #11857

@majetideepak majetideepak requested a review from JkSelf December 31, 2024 20:53
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 31, 2024
Copy link

netlify bot commented Dec 31, 2024

Deploy Preview for meta-velox canceled.

Name Link
🔨 Latest commit 62ea529
🔍 Latest deploy log https://app.netlify.com/sites/meta-velox/deploys/6776fa3c4c1c9800088b1f75

@majetideepak majetideepak force-pushed the fix-hdfs branch 3 times, most recently from a9150ad to 3c22590 Compare January 1, 2025 15:25
Copy link
Collaborator

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for your fix and refactor.

@majetideepak majetideepak added the ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall label Jan 2, 2025
@facebook-github-bot
Copy link
Contributor

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@kevinwilfong
Copy link
Contributor

@majetideepak I just merged #11997 which should fix the build failures, could you rebase so we get the test signals?

@majetideepak
Copy link
Collaborator Author

@kevinwilfong done. Thanks.

@facebook-github-bot
Copy link
Contributor

@kevinwilfong has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@kevinwilfong merged this pull request in 1d30270.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged ready-to-merge PR that have been reviewed and are ready for merging. PRs with this tag notify the Velox Meta oncall
Projects
None yet
Development

Successfully merging this pull request may close these issues.

velox_hdfs_file_test HdfsFileSystemTest SetUpTestSuite Exceptions in CI
4 participants