Remove string encoding enum #183
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
kgpai
force-pushed
the
remove_ascii_encoding
branch
from
5c0dca1 to
03f9324
Compare
mbasmanova
approved these changes
Sep 9, 2021
| case StringEncodingMode::MOSTLY_ASCII: | ||
| Func<StringEncodingMode::MOSTLY_ASCII>::apply(args...); | ||
| return; | ||
| static void apply(const bool mode, Params... args) { |
There was a problem hiding this comment.
nit: mode -> isAscii for clarity
kgpai
force-pushed
the
remove_ascii_encoding
branch
from
03f9324 to
5fc2f06
Compare
|
@kgpai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
kgpai
force-pushed
the
remove_ascii_encoding
branch
from
36992b1 to
f02ad11
Compare
|
@kgpai has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
simuthus-fb
added a commit
to simuthus-fb/velox
that referenced
this pull request
Jan 24, 2023
Summary: X-link: facebookincubator/katran#183 X-link: facebook/openr#143 X-link: facebook/fbthrift#536 X-link: facebook/fb303#33 X-link: facebook/folly#1924 FBOSS OSS on-diff job is failing due to random test failures. Disabling the tests for now to avoid build breakages. Reviewed By: shri-khare Differential Revision: D42550176 fbshipit-source-id: fb887cd092adae0a57f7a377fa7e1941c46c5afd
PHILO-HE
pushed a commit
to PHILO-HE/velox
that referenced
this pull request
Apr 10, 2023
* fix bloom filter validation Encounter this error when we run q93, we increase settings "spark.sql.optimizer.runtime.bloomFilter.maxNumItems" for our tests. Constants check happens before min comparsion, so when next grouping comes, it failed with not constant value error. --------- Co-authored-by: zhli1142015 <zhli@pczhlich.fareast.corp.microsoft.com>
rui-mo
pushed a commit
to rui-mo/velox
that referenced
this pull request
Apr 23, 2023
* fix bloom filter validation Encounter this error when we run q93, we increase settings "spark.sql.optimizer.runtime.bloomFilter.maxNumItems" for our tests. Constants check happens before min comparsion, so when next grouping comes, it failed with not constant value error. --------- Co-authored-by: zhli1142015 <zhli@pczhlich.fareast.corp.microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the recent ascii compute changes (See: #32), the StringEncoding enum is redundant and no longer required.