Back out "Pre-load lazy vectors that are referenced by multiple sub expressions" #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xpressions" Summary: Original commit changeset: d88dc5ec5cb0 Original Phabricator Diff: D38583570 (facebookincubator@0062f14) Reviewed By: bikramSingh91 Differential Revision: D38710882 fbshipit-source-id: c1a2b890f6d62807db5b9057f78a91b6486e84e0
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D38710882 |
|
Could you provide us some background on why the previous fix was reverted? Because we found the previous fix was useful to fix the issue we met. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Original commit changeset: d88dc5ec5cb0
Original Phabricator Diff: D38583570 (0062f14)
Reviewed By: bikramSingh91
Differential Revision: D38710882