Fixed FileHandleTest.localFile test #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D30262592 |
Summary: Pull Request resolved: facebookincubator/velox#28 When running stress tests, multiple process/threads are running the same thing, reading/writing the same file "/tmp/test", which in turn creates a cross process/threads race condition. Reviewed By: mbasmanova Differential Revision: D30262592 fbshipit-source-id: 1e9d4f06abac78b098316c817b9960ef1a16b72a
tanjialiang
force-pushed
the
export-D30262592
branch
from
f9bdb79
to
51e424e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D30262592 |
|
This pull request has been merged in b66d9d1. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 14, 2022
Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
shiyu-bytedance
pushed a commit
to shiyu-bytedance/velox-1
that referenced
this pull request
Aug 18, 2022
…incubator#28) Summary: X-link: facebook/fb303#28 X-link: facebook/fboss#115 X-link: facebook/folly#1736 X-link: facebook/proxygen#403 X-link: facebook/fbthrift#488 This adds a way to pass arguments to the `b2` build tool, used by Boost. This is needed in order to link a getdeps built boost into an relocatable `.so`. The motivating use case is that we need to statically link Boost into a native library used by a python wheel, which must be relocatable. This functionality already exists for CMake-based projects. Reviewed By: mackorone Differential Revision: D34796774 fbshipit-source-id: 0d6a9f4703865dc02048b87e77394c44ef646af6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: When running stress tests, multiple process/threads are running the same thing, reading/writing the same file "/tmp/test", which in turn creates a cross process/threads race condition.
Differential Revision: D30262592