Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory pool dtor race in VeloxSubstraitRoundTripPlanConverterTest #2828

Closed
wants to merge 1 commit into from

Commits on Oct 13, 2022

  1. Fix memory pool dtor race in VeloxSubstraitRoundTripPlanConverterTest (

    …facebookincubator#2828)
    
    Summary:
    This is caused by the async task deletion (task dtor triggered by
    async driver removal). The fix is to add memory counting wait in
    Substrait2VeloxValuesNodeConversionTest dtor.
    
    Pull Request resolved: facebookincubator#2828
    
    Differential Revision: D40332245
    
    Pulled By: xiaoxmeng
    
    fbshipit-source-id: 3344c92d57e98d38f3ba860c75125039b6c4b0b7
    xiaoxmeng authored and facebook-github-bot committed Oct 13, 2022
    Configuration menu
    Copy the full SHA
    6b22664 View commit details
    Browse the repository at this point in the history