Use index based Table->File columns mapping. #6531
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for meta-velox canceled.
|
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
spershin
force-pushed
the
export-D49117889
branch
from
63ffc47 to
ccb8949
Compare
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 12, 2023
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Differential Revision: D49117889
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
spershin
force-pushed
the
export-D49117889
branch
from
ccb8949 to
7bf4b78
Compare
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 13, 2023
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Differential Revision: D49117889
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 13, 2023
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Differential Revision: D49117889
spershin
force-pushed
the
export-D49117889
branch
from
7bf4b78 to
1225e82
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
spershin
force-pushed
the
export-D49117889
branch
from
1225e82 to
235e6b4
Compare
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 14, 2023
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889
spershin
force-pushed
the
export-D49117889
branch
from
235e6b4 to
a259308
Compare
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 14, 2023
Summary: Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889
spershin
force-pushed
the
export-D49117889
branch
from
a259308 to
06516a6
Compare
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D49117889 |
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 14, 2023
Summary: Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: 3daa876c1c186f09bd1abd2c7088bac5096f9d26
|
This pull request has been merged in 580e81a. |
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 14, 2023
Summary: Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987
spershin
pushed a commit
to spershin/velox-1
that referenced
this pull request
Sep 14, 2023
Summary: Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Summary: Pull Request resolved: #6579 Addressing lints and comments from D49117889 (#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: fbc92b32c0db9b3b284fa9c683fa78d7feeb43c3
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6531 Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889 fbshipit-source-id: 423d94cb892003cf0ec705a936aac46869835f17
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6579 Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: fbc92b32c0db9b3b284fa9c683fa78d7feeb43c3
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6531 Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889 fbshipit-source-id: 423d94cb892003cf0ec705a936aac46869835f17
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6579 Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: fbc92b32c0db9b3b284fa9c683fa78d7feeb43c3
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6531 Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889 fbshipit-source-id: 423d94cb892003cf0ec705a936aac46869835f17
codyschierbeck
pushed a commit
to codyschierbeck/velox
that referenced
this pull request
Sep 27, 2023
Summary: Pull Request resolved: facebookincubator#6579 Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: fbc92b32c0db9b3b284fa9c683fa78d7feeb43c3
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6531 Presto by default uses index based column mapping. It has a connector config prop "hive.orc.use-column-names" to use names. Make Velox use index based column mapping by default. For this we simply rename fields in the file schema using table schema. We also check the type compatibility of the fields. Underneath the code still uses the name mapping, but since we adjusted field names in the file schema using indices, it is equivalent to index mapping. In the future the internal code might hande this on its own and this workaround with column renaming might not be needed. If "hive.orc.use-column-names" is passed - we don't perform renaming and work as before. GH issue: facebookincubator#6466 Reviewed By: Yuhta Differential Revision: D49117889 fbshipit-source-id: 423d94cb892003cf0ec705a936aac46869835f17
ericyuliu
pushed a commit
to ericyuliu/velox
that referenced
this pull request
Oct 12, 2023
Summary: Pull Request resolved: facebookincubator#6579 Addressing lints and comments from D49117889 (facebookincubator#6531). - Using TypePtr instead of std::shared_ptr<const Type> in some places. - Throwing for bad indices in ArrayType::nameOf() and MapType::nameOf(). - Moving TypePtr in some places instead of copying. - Fixing 'use after move'. Reviewed By: Yuhta Differential Revision: D49291987 fbshipit-source-id: fbc92b32c0db9b3b284fa9c683fa78d7feeb43c3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Presto by default uses index based column mapping.
It has a connector config prop "hive.orc.use-column-names" to use names.
Make Velox use index based column mapping by default.
For this we simply rename fields in the file schema using table schema.
We also check the type compatibility of the fields.
Underneath the code still uses the name mapping, but since we adjusted
field names in the file schema using indices, it is equivalent to index mapping.
In the future the internal code might hande this on its own and this workaround
with column renaming might not be needed.
If "hive.orc.use-column-names" is passed - we don't perform renaming and
work as before.
GH issue: #6466
Differential Revision: D49117889