Fix fast path in map Presto function for input arrays with nulls #7862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
xiaoxmeng
approved these changes
Dec 4, 2023
velox/functions/prestosql/Map.cpp
Outdated
| @@ -306,6 +306,9 @@ class MapFunction : public exec::VectorFunction { | |||
| return false; | |||
| } | |||
| for (auto row = 0; row < keys->size(); ++row) { | |||
| if (keys->isNullAt(row) != values->isNullAt(row)) { | |||
There was a problem hiding this comment.
Is possible that keys and values are both null? Thanks!
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in add8303. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fast path in the "map" Presto function could produce invalid MapVector if input
arrays had null rows with out-of-bounds offsets/sizes.
Fixes #7861