Avoid crashes in rowGroupUncompressedSize due to column index being o…

[makagonov]

fixes #9222

Turns out that in the getParquetColumnInfo function, the column was incremented twice for array types, which would result in out-of-bounds vector access down the road. We could confirm it in Uber by deploying the VELOX_CHECK_LT statements in the code, where we started seeing tons of logs like:

VeloxRuntimeError: type.column() < fileMetaData_->row_groups[rowGroupIndex].columns.size() (228 vs. 228) type column: 228, columns.size(): 228 Split [Hive: gs://....parquet 671088640 - 134217728] Task 20240308_025912_03027_rt9ch.1.0.32.0

The crash was not happening frequently because the [] operator on vector does not do out-of-bounds check and would result in an undefined behavior in case if the code tries to access an element at wrong index. Undefined behavior does not necessarily mean you'll get an error: you might, but you might instead get some result that doesn't make much sense.

[facebook-github-bot]

Hi @makagonov!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[netlify]

✅ Deploy Preview for meta-velox canceled.

Name	Link
🔨 Latest commit	5df577e
🔍 Latest deploy log	https://app.netlify.com/sites/meta-velox/deploys/65fddeba94dcc3000823bd96

[qqibrow]

for my understanding, why here it's not ParquetTypeWithId::kNonLeaf but columnIdx - 1?

[makagonov]

the else statement is for the leaf type columns. If the column is a repeated type (like array), it would have the same column index as the column itself.

[yingsu00]

closing with #9187