Fix makeScanSpec wrong index issue if skip rowindex column #9866
+12
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox canceled.
|
|
@Yuhta for help review, thank you! |
ping again |
Yuhta
reviewed
May 22, 2024
Yuhta
reviewed
May 23, 2024
Yuhta
reviewed
May 23, 2024
Yuhta
approved these changes
May 23, 2024
Yuhta
added
the
ready-to-merge
…a/fix_row_index_bug
|
@gaoyangxiaozhu CI is red. Would you take a look? |
|
@mbasmanova has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@mbasmanova merged this pull request in 0f39740. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…ncubator#9866) Summary: 1. correct spec channel index if skip `kRowIndex` column, this fixing below query if `_tmp_row_index_column` be marked to `kRowIndex` type. Basically, all scan would fail if `kRowIndex` type column is selected before data column. ``` select _tmp_row_index_column, a from table ``` 2. A column should always be treat as `row index` column if engine mark it to `kRowIndex` type check this facebookincubator#9867 for log detail Pull Request resolved: facebookincubator#9866 Reviewed By: Yuhta Differential Revision: D57770761 Pulled By: mbasmanova fbshipit-source-id: 0f0ddbf76c609deb854503eddcbb4dbe7748daad
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…ncubator#9866) Summary: 1. correct spec channel index if skip `kRowIndex` column, this fixing below query if `_tmp_row_index_column` be marked to `kRowIndex` type. Basically, all scan would fail if `kRowIndex` type column is selected before data column. ``` select _tmp_row_index_column, a from table ``` 2. A column should always be treat as `row index` column if engine mark it to `kRowIndex` type check this facebookincubator#9867 for log detail Pull Request resolved: facebookincubator#9866 Reviewed By: Yuhta Differential Revision: D57770761 Pulled By: mbasmanova fbshipit-source-id: 0f0ddbf76c609deb854503eddcbb4dbe7748daad
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
kRowIndexcolumn, this fixing below query if_tmp_row_index_columnbe marked tokRowIndextype. Basically, all scan would fail ifkRowIndextype column is selected before data column.row indexcolumn if engine mark it tokRowIndextypecheck this #9867 for log detail