Fix Parquet V2 page reading when max def/rep levels are 0 #9939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
✅ Deploy Preview for meta-velox ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The existing code did not skip the definition and repetition level arrays if the maxDefine_ and maxRepeat_ are both zero but these arrays were actually more than 0 bytes. This commit fixes this problem and always uses pageHeader.data_page_header_v2.definition_levels_byte_length and pageHeader.data_page_header_v2.repetition_levels_byte_length as the array lengths because these values are guranteed to exist.
yingsu00
force-pushed
the
ParquetV2PageFix
branch
from
b2200f1 to
01d536b
Compare
Yuhta
approved these changes
May 30, 2024
|
@Yuhta has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Conbench analyzed the 1 benchmark run on commit There were no benchmark performance regressions. 🎉 The full Conbench report has more details. |
karteekmurthys
pushed a commit
to karteekmurthys/velox
that referenced
this pull request
Jun 4, 2024
…cubator#9939) Summary: The existing code did not skip the definition and repetition level arrays if the `maxDefine_` and `maxRepeat_` are both zero but these arrays were actually more than 0 bytes. This commit fixes this problem and always uses `pageHeader.data_page_header_v2.definition_levels_byte_length` and `pageHeader.data_page_header_v2.repetition_levels_byte_length` as the array lengths because these values are guaranteed to exist. Fixes facebookincubator#9924 Pull Request resolved: facebookincubator#9939 Reviewed By: pedroerp Differential Revision: D57975496 Pulled By: Yuhta fbshipit-source-id: d9a8dde1973942a3b9cc5212db24e38c2ff3983d
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9939) Summary: The existing code did not skip the definition and repetition level arrays if the `maxDefine_` and `maxRepeat_` are both zero but these arrays were actually more than 0 bytes. This commit fixes this problem and always uses `pageHeader.data_page_header_v2.definition_levels_byte_length` and `pageHeader.data_page_header_v2.repetition_levels_byte_length` as the array lengths because these values are guaranteed to exist. Fixes facebookincubator#9924 Pull Request resolved: facebookincubator#9939 Reviewed By: pedroerp Differential Revision: D57975496 Pulled By: Yuhta fbshipit-source-id: d9a8dde1973942a3b9cc5212db24e38c2ff3983d
Joe-Abraham
pushed a commit
to Joe-Abraham/velox
that referenced
this pull request
Jun 7, 2024
…cubator#9939) Summary: The existing code did not skip the definition and repetition level arrays if the `maxDefine_` and `maxRepeat_` are both zero but these arrays were actually more than 0 bytes. This commit fixes this problem and always uses `pageHeader.data_page_header_v2.definition_levels_byte_length` and `pageHeader.data_page_header_v2.repetition_levels_byte_length` as the array lengths because these values are guaranteed to exist. Fixes facebookincubator#9924 Pull Request resolved: facebookincubator#9939 Reviewed By: pedroerp Differential Revision: D57975496 Pulled By: Yuhta fbshipit-source-id: d9a8dde1973942a3b9cc5212db24e38c2ff3983d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing code did not skip the definition and repetition level arrays if the
maxDefine_andmaxRepeat_are both zero but these arrays were actually more than 0 bytes. This commit fixes this problem and always usespageHeader.data_page_header_v2.definition_levels_byte_lengthandpageHeader.data_page_header_v2.repetition_levels_byte_lengthas the array lengths because these values are guaranteed to exist.Fixes #9924