Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Run evaluation on first iteration #108

Merged
merged 2 commits into from
Jul 9, 2024
Merged

[Feature] Run evaluation on first iteration #108

merged 2 commits into from
Jul 9, 2024

Conversation

matteobettini
Copy link
Collaborator

@matteobettini matteobettini commented Jul 9, 2024 •
edited
Loading

The majority of users seems to be wanting to see evaluation results on the first iteration.

So this PR runs evaluation also on first iter and then every evaluation_interval frames

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 9, 2024
@matteobettini matteobettini changed the title [Feature] Run evaluation also on first iteration [Feature] Run evaluation on first iteration Jul 9, 2024
@matteobettini matteobettini added the enhancement New feature or request label Jul 9, 2024
@matteobettini matteobettini merged commit 2d7ac79 into main Jul 9, 2024
13 checks passed
@matteobettini matteobettini deleted the evaluation branch July 9, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matteobettini @facebook-github-bot