Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix discrete SAC #40

Merged
merged 3 commits into from
Dec 21, 2023
Merged

[BugFix] Fix discrete SAC #40

merged 3 commits into from
Dec 21, 2023

Conversation

matteobettini
Copy link
Collaborator

No description provided.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@matteobettini matteobettini added smacv2 Label to be assigned to run the SMACv2 tests and removed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Dec 20, 2023
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 21, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (492d1c6) 87.42% compared to head (59ea12c) 84.04%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
- Coverage   87.42%   84.04%   -3.38%     
==========================================
  Files          56       56              
  Lines        2576     2576              
==========================================
- Hits         2252     2165      -87     
- Misses        324      411      +87

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matteobettini matteobettini changed the title [Env] Fix SMAC [BugFix] Fix discrete SAC Dec 21, 2023
@matteobettini matteobettini marked this pull request as ready for review December 21, 2023 18:58
@matteobettini matteobettini merged commit 75bc507 into main Dec 21, 2023
12 checks passed
@matteobettini matteobettini deleted the fix_smac branch December 21, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. smacv2 Label to be assigned to run the SMACv2 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matteobettini @codecov-commenter @facebook-github-bot