Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

Move Dataloader Wrappers to OSS #455

Closed
wants to merge 1 commit into from
Closed

Move Dataloader Wrappers to OSS #455

wants to merge 1 commit into from

Conversation

mannatsingh
Copy link
Contributor

Summary: This will be helpful for OSS users who implement their own Iterable datasets.

Differential Revision: D20605900

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Mar 24, 2020
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20605900

mannatsingh added a commit to mannatsingh/ClassyVision that referenced this pull request Mar 24, 2020
@mannatsingh @facebook-github-bot
Move Dataloader Wrappers to OSS (facebookresearch#455)
bd6dc5d 
Summary:
Pull Request resolved: facebookresearch#455

This will be helpful for OSS users who implement their own Iterable datasets.

Differential Revision: D20605900

fbshipit-source-id: 321b4c929e53fc3d998a15e623a1ae9859215446
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20605900

mannatsingh added a commit to mannatsingh/ClassyVision that referenced this pull request Mar 24, 2020
@mannatsingh @facebook-github-bot
Move Dataloader Wrappers to OSS (facebookresearch#455)
882a224 
Summary:
Pull Request resolved: facebookresearch#455

This will be helpful for OSS users who implement their own Iterable datasets.

Differential Revision: D20605900

fbshipit-source-id: c5039f948d60cb160d6cc11a68d182c5a8ddefeb
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20605900

@miguelvr
Copy link
Contributor

in DataloaderLimitWrapper the limit is expected to be set for a replica right?

something like:

limit = total_size // num_replicas

@mannatsingh
Copy link
Contributor Author

@miguelvr it should be the total number of batches per phase - the global number of samples divided by the global batch size.
You can look at the code for SyntheticImageClassificationStreamingDataset to get a better idea.

@miguelvr
Copy link
Contributor

@mannatsingh I realized that, managed to get my dataset working due to this! Thanks

This was referenced Mar 25, 2020
Closed
Open
mannatsingh added a commit to mannatsingh/ClassyVision that referenced this pull request Mar 25, 2020
@mannatsingh @facebook-github-bot
Move Dataloader Wrappers to OSS (facebookresearch#455)
907716a 
Summary:
Pull Request resolved: facebookresearch#455

This will be helpful for OSS users who implement their own Iterable datasets.

Reviewed By: vreis

Differential Revision: D20605900

fbshipit-source-id: 4ecf99cbe3f7aa69faed98afdcb11a96f136f396
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20605900

@mannatsingh @facebook-github-bot
Move Dataloader Wrappers to OSS (facebookresearch#455)
9bd745e 
Summary:
Pull Request resolved: facebookresearch#455

This will be helpful for OSS users who implement their own Iterable datasets.

Reviewed By: vreis

Differential Revision: D20605900

fbshipit-source-id: 9243ab7be3e47e55f4e2ae6a7bdb3b27ae10be92
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D20605900

@facebook-github-bot
Copy link
Contributor

This pull request has been merged in b31f30b.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mannatsingh @facebook-github-bot @miguelvr