Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the part that reloads the model using CAPE1d(). #101

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

muririn
Copy link

@muririn muririn commented May 17, 2023

Traceback (most recent call last):
  File "/home/ki-nismr/C2OpenMP/m2/CodeGen/codegen_sources/model/train.py", line 1064, in <module>
    main(params)
  File "/home/ki-nismr/C2OpenMP/m2/CodeGen/codegen_sources/model/train.py", line 902, in main
    encoder, decoder = build_model(params, data["dico"])
  File "/home/ki-nismr/anaconda3/envs/codegen_3_10/lib/python3.10/site-packages/torch/autograd/grad_mode.py", line 27, in decorate_context
    return func(*args, **kwargs)
  File "/home/ki-nismr/C2OpenMP/m2/CodeGen/codegen_sources/model/src/model/__init__.py", line 246, in build_model
    reload_transformer(params, enc_path, dico, encoder, "encoder", gpu=gpu)
  File "/home/ki-nismr/C2OpenMP/m2/CodeGen/codegen_sources/model/src/model/__init__.py", line 347, in reload_transformer
    reload_position_embeddings(reloaded, model, model_type)
  File "/home/ki-nismr/C2OpenMP/m2/CodeGen/codegen_sources/model/src/model/__init__.py", line 515, in reload_position_embeddings
    current_size = encoder.position_embeddings.weight.size()[0]
  File "/home/ki-nismr/anaconda3/envs/codegen_3_10/lib/python3.10/site-packages/torch/nn/modules/module.py", line 1207, in __getattr__
    raise AttributeError("'{}' object has no attribute '{}'".format(
AttributeError: 'CAPE1d' object has no attribute 'weight'

Sorry if I made a mistake in my first pull request.
When I try to reload a model using CAPE1d, I get the above error.
I think reload_position_embeddings() in codegen_sources/model/src/model/init.py is not necessary when using CAPE1d().
Please confirm this.

@facebook-github-bot
Copy link

Hi @muririn!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants