[util] Add download error handler for missing URLs.

facebookresearch · May 25, 2021 · 29f6000 · 29f6000
1 parent 13990a3
commit 29f6000
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/compiler_gym/util/download.py b/compiler_gym/util/download.py
@@ -68,6 +68,9 @@ def _do_download_attempt(url: str, sha256: Optional[str]) -> bytes:
 
 
 def _download(urls: List[str], sha256: Optional[str], max_retries: int) -> bytes:
+    if not urls:
+        raise ValueError("No URLs to download")
+
     # Cache hit.
     if sha256 and cache_path(f"downloads/{sha256}").is_file():
         with open(str(cache_path(f"downloads/{sha256}")), "rb") as f:

diff --git a/tests/util/download_test.py b/tests/util/download_test.py
@@ -98,5 +98,10 @@ def patched_download(*args):
         download.download("example", sha256="123")
 
 
+def test_download_no_urls():
+    with pytest.raises(ValueError, match="No URLs to download"):
+        download.download(urls=[])
+
+
 if __name__ == "__main__":
     main()