[service] Reduce severity of logging messages on reset() retry.

facebookresearch · Mar 4, 2022 · 45590cc · 45590cc
1 parent 93eafa3
commit 45590cc
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/compiler_gym/envs/compiler_env.py b/compiler_gym/envs/compiler_env.py
@@ -735,7 +735,14 @@ def reset(  # pylint: disable=arguments-differ
 
         def _retry(error) -> Optional[ObservationType]:
             """Abort and retry on error."""
-            logger.warning("%s during reset(): %s", type(error).__name__, error)
+            # Log the error that we are recovering from, but treat
+            # ServiceIsClosed errors as unimportant since we know what causes
+            # them.
+            log_severity = (
+                logger.debug if isinstance(error, ServiceIsClosed) else logger.warning
+            )
+            log_severity("%s during reset(): %s", type(error).__name__, error)
+
             if self.service:
                 try:
                     self.service.close()

diff --git a/compiler_gym/service/connection.py b/compiler_gym/service/connection.py
@@ -204,7 +204,7 @@ def __call__(
             except ValueError as e:
                 if str(e) == "Cannot invoke RPC on closed channel!":
                     raise ServiceIsClosed(
-                        f"RPC communication failed with message: {e}"
+                        "RPC communication failed because channel is closed"
                     ) from None
                 raise e
             except grpc.RpcError as e: