Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename Dataset.hidden to Dataset.deprecated #219

Closed
ChrisCummins opened this issue Apr 27, 2021 · 0 comments · Fixed by #233
Closed

Rename Dataset.hidden to Dataset.deprecated #219

ChrisCummins opened this issue Apr 27, 2021 · 0 comments · Fixed by #233
Assignees
@ChrisCummins
Labels
Enhancement New feature or request
Milestone
v0.1.8

Comments

@ChrisCummins
Copy link
Contributor

🚀 Feature

Rename the hidden property to deprecated, and include a deprecation message.

Motivation

This removes the need for ad-hoc install()-time warnings, see CBenchLegacyDataset.
@ChrisCummins ChrisCummins added the Enhancement New feature or request label Apr 27, 2021
@ChrisCummins ChrisCummins added this to the v0.1.8 milestone Apr 27, 2021
@ChrisCummins ChrisCummins mentioned this issue Apr 29, 2021
Merged
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Apr 29, 2021
@ChrisCummins
Add automated deprecation warnings to the Dataset class.
e5276bb 
This replaces the boolean `hidden` value with a `deprecated` message,
which is emitted automatically on a call to `install()`.

Issue facebookresearch#45. Fixes facebookresearch#219.
ChrisCummins added a commit to ChrisCummins/CompilerGym that referenced this issue Apr 29, 2021
@ChrisCummins
Add automated deprecation warnings to the Dataset class.
8f836c4 
This replaces the boolean `hidden` value with a `deprecated` message,
which is emitted automatically on a call to `install()`.

Issue facebookresearch#45. Fixes facebookresearch#219.
@ChrisCummins ChrisCummins self-assigned this Jul 13, 2021
bwasti pushed a commit to bwasti/CompilerGym that referenced this issue Aug 3, 2021
@ChrisCummins @bwasti
Add automated deprecation warnings to the Dataset class.
c9d058a 
This replaces the boolean `hidden` value with a `deprecated` message,
which is emitted automatically on a call to `install()`.

Issue facebookresearch#45. Fixes facebookresearch#219.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChrisCummins ChrisCummins

Labels
Enhancement New feature or request
Projects
None yet
Milestone
v0.1.8
Development

Successfully merging a pull request may close this issue.

Add automated deprecation warnings to the Dataset class. ChrisCummins/CompilerGym
1 participant
@ChrisCummins