Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[env] Wrap all RPC calls in reset() in retry loop. #423

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

ChrisCummins
Copy link
Contributor

@ChrisCummins ChrisCummins commented Sep 22, 2021

This adds a new Docker image that contains a preconfigured CompilerGym install that can be used to run environments in an isolated container and communicated with over gRPC.

Summary of changes:

  • Added a new --run_on_port=1234 flag to compiler_gym.bin.service that starts a service on the given port.
  • Made the --service and --local-service-binary flags compatible with the new datasets API (Redesign of DataSet API #45).
  • Made Benchmark.from_file() compatible with distributed services by reading the file contents into a protobuf, rather than embedding the local filesystem path (Redesign of DataSet API #45).
  • Fixed an unrelated type error bug when switching reward space midway through an episode.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 22, 2021
@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2021

Codecov Report

Merging #423 (653f65d) into development (03f0a3b) will increase coverage by 0.00%.
The diff coverage is 50.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##           development     #423   +/-   ##
============================================
  Coverage        87.29%   87.30%           
============================================
  Files              100      100           
  Lines             5746     5749    +3     
============================================
+ Hits              5016     5019    +3     
  Misses             730      730           
Impacted Files Coverage Δ
compiler_gym/envs/compiler_env.py 88.91% <50.00%> (+0.33%) ⬆️
compiler_gym/envs/llvm/datasets/cbench.py 78.37% <0.00%> (-0.78%) ⬇️
compiler_gym/envs/gcc/service/gcc_service.py 97.75% <0.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03f0a3b...653f65d. Read the comment docs.

@ChrisCummins ChrisCummins merged commit 0f76d42 into facebookresearch:development Sep 23, 2021
@ChrisCummins ChrisCummins deleted the reset-rety branch September 23, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants