-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hardening patchset #578
Hardening patchset #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Codecov Report
@@ Coverage Diff @@
## development #578 +/- ##
===============================================
+ Coverage 88.09% 88.27% +0.18%
===============================================
Files 114 114
Lines 6693 6705 +12
===============================================
+ Hits 5896 5919 +23
+ Misses 797 786 -11
Continue to review full report at Codecov.
|
This extends the logic for extracting #include search paths to also extract the location of the -lSystem library from the host target. This is to enable compiler binary support on macOS.
Fix a bug in which connection live was reported the wrong way around (dead services were logged as alive and alive connections as dead. Also makes the representations more verbose to better explain what type and state they are in.
boost::asio::io_service is only for backwards compatibility.
This corrects my use of the boost::process API whereby llvm-size child processes could become detached from the parent environment service and be left as zombies. I found this issue will attempting to reproduce facebookresearch#572. I'm not sure if this bug is relevant.
f287e36
to
070e21c
Compare
9076b61
to
f6c1aa1
Compare
Runtime observation space is now supported.
This patch set contains a handful of fixes for issues discovered while trying to track down #572:
get_system_includes()
withget_system_library_flags()
, a function that returns a list of-isystem
flags, and a-L
flag for macOS. This enables optimizing for runtime on macOS.